Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Repo to Include Updates Made for SCC #37

Merged
merged 5 commits into from
May 19, 2022
Merged

Update Repo to Include Updates Made for SCC #37

merged 5 commits into from
May 19, 2022

Conversation

lrennels
Copy link
Collaborator

This PR updates a few things to be consistent with partial-changes made for SCC calculations in a separate project. These include:

  1. Use the dimension name ciam_country instead of region in slrcost_GAMSmatch.jl
  2. Add the performance improvements to slrcost_GAMSmatch.jl
  3. Add the option to calculate the VSL both endogenously (as done originally) and exogenously (added as an option for use cases such as VSL)

lrennels
lrennels commented May 19, 2022
View reviewed changes
src/ciam.jl Show resolved Hide resolved
tonyewong
tonyewong approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@tonyewong tonyewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm.

src/ciam.jl Show resolved Hide resolved
src/slrcost.jl Show resolved Hide resolved
@tonyewong tonyewong merged commit 9d9c3fa into master May 19, 2022
@tonyewong tonyewong deleted the harmonize-scc-changes branch May 19, 2022 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyewong tonyewong tonyewong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lrennels @tonyewong